Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add clone_channel method to guild #794

Merged
merged 8 commits into from
May 23, 2022
Merged

feat: Add clone_channel method to guild #794

merged 8 commits into from
May 23, 2022

Conversation

Nanrech
Copy link
Contributor

@Nanrech Nanrech commented May 17, 2022

About

This PR adds the clone_channel method to the guild class.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

EepyElvyra
EepyElvyra suggested changes May 17, 2022
View reviewed changes
interactions/api/models/guild.py Outdated Show resolved Hide resolved
@Nanrech Nanrech requested a review from EepyElvyra May 17, 2022 22:35
Toricane
Toricane suggested changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loop modification

interactions/api/models/guild.py Outdated Show resolved Hide resolved
@Toricane Toricane added documentation Improvements or additions to documentation enhancement New feature or request labels May 18, 2022
@Nanrech @Toricane
Update interactions/api/models/guild.py
8519973 
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
@Nanrech Nanrech requested a review from Toricane May 18, 2022 07:43
Toricane
Toricane suggested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion

interactions/api/models/guild.py Outdated Show resolved Hide resolved
Toricane
Toricane approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Toricane Toricane merged commit d46d27a into interactions-py:unstable May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EepyElvyra EepyElvyra EepyElvyra approved these changes

@Toricane Toricane Toricane approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nanrech @Toricane @EepyElvyra